Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tag importers into a single class #143

Closed
kaklakariada opened this issue May 23, 2018 · 2 comments
Closed

Refactor tag importers into a single class #143

kaklakariada opened this issue May 23, 2018 · 2 comments

Comments

@kaklakariada
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When importing code tags from *.java files using the legacy tag importer the import fails because the 'normal' tag importer also uses *.java.

Describe the solution you'd like
A solution would be to allow configuring each importer for which files it is responsible.

Describe alternatives you've considered
Another option would be to order the importers by priority (giving the legacy tag importer higher priority) and use the first one without checking the others.
@kaklakariada
Copy link
Contributor Author

We decided to integrate legacy tag importer into the existing tag importer to avoid this.

@kaklakariada kaklakariada changed the title Allow configuring importers Refactor tag importers into a single class Aug 2, 2018
kaklakariada added a commit that referenced this issue Aug 2, 2018
@kaklakariada
test(#143): Skip file permissions test under windows
9c81090
kaklakariada added a commit that referenced this issue Aug 2, 2018
@kaklakariada
feat(#143): Unify importers for long and short tags
5d2d3db
@kaklakariada kaklakariada mentioned this issue Aug 2, 2018
Merged
kaklakariada added a commit that referenced this issue Aug 3, 2018
@kaklakariada
refactor(#143): Extract regex matching and iteration
c8f4a61
kaklakariada added a commit that referenced this issue Aug 3, 2018
@kaklakariada
refactor(#143): Implement review findings
05365e1
kaklakariada added a commit that referenced this issue Aug 3, 2018
@kaklakariada
refactor(#143): Improve error message for invalid revision
c63bc33
kaklakariada added a commit that referenced this issue Aug 3, 2018
@kaklakariada
test(#143): Add test to improve coverage
b8fdaaa
kaklakariada added a commit that referenced this issue Aug 3, 2018
@kaklakariada
refactor(#143): Fix review finding
59dd2a2
@kaklakariada
Copy link
Contributor Author

Implemented in #167

redcatbear pushed a commit that referenced this issue Sep 14, 2018
@kaklakariada
Merge pull request #167 from itsallcode/story/#143-refactor-tag-importer
358d5f0 
Story/#143 unify short & long tag importer
@redcatbear redcatbear mentioned this issue Oct 13, 2018
Merged
kaklakariada added a commit that referenced this issue Nov 11, 2018
@kaklakariada
#143: Fetch git history to provide sonar blame information
767251a
kaklakariada added a commit that referenced this issue Nov 11, 2018
@kaklakariada
Merge pull request #193 from itsallcode/feature/#143-reenable-sonar-2
05eec61 
#143: Fetch git history to provide sonar blame information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaklakariada