Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid configuring mocks as lenient #256

Closed
kaklakariada opened this issue Feb 25, 2021 · 0 comments · Fixed by #362
Closed

Avoid configuring mocks as lenient #256

kaklakariada opened this issue Feb 25, 2021 · 0 comments · Fixed by #362
Assignees
@kaklakariada
Labels
refactoring Code improvement without behavior change
Projects
OpenFastTrace (deprecated)

Comments

@kaklakariada
Copy link
Contributor

kaklakariada commented Feb 25, 2021 •
edited

Mocks are currently configured as lenient. We refactor the unit tests and remove lenient.
This was found during review of #255
@kaklakariada kaklakariada added the refactoring Code improvement without behavior change label Feb 25, 2021
@kaklakariada kaklakariada added this to TODO in OpenFastTrace (deprecated) via automation Feb 25, 2021
This was referenced Feb 25, 2021
Merged
Closed
@kaklakariada kaklakariada self-assigned this Jan 5, 2023
@kaklakariada kaklakariada mentioned this issue Jan 6, 2023
Merged
kaklakariada added a commit that referenced this issue Dec 16, 2023
@kaklakariada @redcatbear
#256: Avoid lenient mocks (#362)
6466a4b 
* #342: Restructure changelog

* Apply suggestions from code review

Co-authored-by: Christoph Pirkl <github@chp1.net>

* #342: Restructure changelog

* #342: Updated versions.

* #359: Improve logo transparency

* #359: Updated version number and changelog.

* #356: Fix warning in codeql-analysis.yml

* Upgrade test dependencies

* #246: Avoid configuring mocks as lenient

* Fix warning under Java 17

OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=deny; support was removed in 17.0

* Test with Java 19

* Fix integration test

* Fix compiler warnings

* Skip tests that require the SecurityManager

Java 19ff does not support the SecurityManager any more.

* Update release date

---------

Co-authored-by: Sebastian Bär <redcatbear@ursus-minor.de>
Co-authored-by: kaklakariada <kaklakariada@users.noreply.github.com>
Co-authored-by: kaklakariada <christoph@users.sourceforge.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
refactoring Code improvement without behavior change
Projects
OpenFastTrace
Archived in project
OpenFastTrace (deprecated)
  
TODO
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#256: Avoid lenient mocks itsallcode/openfasttrace
1 participant
@kaklakariada