Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix template type error #84

Closed
wants to merge 5 commits into from
Closed

Conversation

sbaier1
Copy link

@sbaier1 sbaier1 commented Nov 17, 2020

What this PR does / why we need it:

The template field in ExternalSecrets objects is currently broken, as the K8s client will attempt to decode the object as base64 first, which fails. The correct type has to be used in the internal datastructure.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #83

Other notes for your reviewer:
Not sure if this is the best approach to fix the problem but form my research into the client library this is the specific type intended for this type of usage.

It may also be possible to directly use a Secret type object in the CRD and internal structure and stop having to sacrifice CRD schema structure registration, but that would collide with the intent of other pending issues like #22

Release note:

Fixed an issue that lead to sync errors when trying to use the template field in ExternalSecret objects.

@sbaier1 sbaier1 mentioned this pull request Nov 17, 2020
@sbaier1 sbaier1 closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Templating is broken
1 participant