Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to treat 1 message with multiple attachments as seperate messages #81

Open
sabogalc opened this issue Jan 29, 2021 · 17 comments
Open
Labels
bug Something isn't working

Comments

@sabogalc
Copy link

For example, if someone sends me 17 photos in one message, I cannot put different tapbacks on different photos using SMServer because all 17 photos only give one tapback menu at the top. This also applies to a photo sent together with a text caption, a tapback can only be placed on the photo, not the caption.

@sabogalc
Copy link
Author

Also on an unrelated note, if I pull out of my GameStop shares at a good time I'll finally be able to donate 😎. In the meantime, HOLD 💎🙌

@itsjunetime
Copy link
Owner

Yes, this is definitely an issue -- I only realized it after releasing the update with tapbacks, but it's been on my list so I'll work on it and let you know once I've got it implemented.

GME to the moon, man; thanks for playing your part in this. Mad amounts of respect.

@sabogalc
Copy link
Author

Also on an unrelated note, if I pull out of my GameStop shares at a good time I'll finally be able to donate 😎. In the meantime, HOLD 💎🙌

Unrelated but I have since lost all this money

@itsjunetime
Copy link
Owner

itsjunetime commented Feb 19, 2021

Rip to your stocks man, I'm sorry about that. Appreciate what you did though.

Also, this issue is now somewhat fixed (once I release the next update, of course); reactions will now show (in the web interface) on the specific attachment that they were actually reacting to. I'm working on adding support for sending to a specific attachment/part of message, and should have that implemented soon as well (either in this update or the next).

@sabogalc
Copy link
Author

@itsjunetime
Copy link
Owner

Alright, I think I've got this implemented for most use cases — there are still a few small bugs to iron out but you should expect to see this included in the next update.

@sabogalc
Copy link
Author

Alright! And the stonks are back 😳😳

@itsjunetime itsjunetime added the update pending This issue should be fixed with the next update label Feb 27, 2021
@sabogalc
Copy link
Author

sabogalc commented Mar 14, 2021

I updated to 0.7.4 and it looks really nice!
Screenshot 2021-03-13 234351
110990580-7e4cb000-8341-11eb-90c0-895fb34372fa
Here is a bug I got for displaying the tapbacks (also seen here)

{
  "id": "D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
  "fromMe": true,
  "isTypingMessage": false,
  "description": "We'll show up and he'll be like",
  "flags": 1081349,
  "fileTransferIDs": [
    "72D48466-A535-4C93-AA78-6791A8AB53F1"
  ],
  "chatID": "chat526745548997352517",
  "time": 1615577622383.0002,
  "timeRead": 0,
  "isSOS": false,
  "timeDelivered": 0,
  "isAudioMessage": false,
  "isCancelTypingMessage": false,
  "items": [
    {
      "type": "attachment",
      "payload": {
        "metadata": {
          "size": {
            "width": 500,
            "height": 255
          },
          "id": "72D48466-A535-4C93-AA78-6791A8AB53F1",
          "filename": "AE5727AE-29A7-4E84-B537-17AFD35FEB41.gif",
          "uti": "com.compuserve.gif",
          "mime": "image/gif"
        },
        "id": "p:0/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
        "chatID": "chat526745548997352517",
        "transferID": "72D48466-A535-4C93-AA78-6791A8AB53F1",
        "fromMe": true,
        "time": 1615577622383.0002
      }
    },
    {
      "type": "text",
      "payload": {
        "chatID": "chat526745548997352517",
        "fromMe": true,
        "parts": [
          {
            "type": "text",
            "string": "We'll show up and he'll be like"
          }
        ],
        "id": "p:1/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
        "time": 1615577622383.0002,
        "text": "We'll show up and he'll be like",
        "acknowledgments": [
          {
            "chatID": "chat526745548997352517",
            "sender": "*my friend's email*",
            "associatedID": "p:1/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
            "id": "am:F0716C13-6871-4286-A4A6-3CF3FB0B25CD",
            "fromMe": false,
            "time": 1615577636093.2012,
            "acknowledgmentType": 2003
          }
        ]
      }
    }
  ],
  "service": "iMessage",
  "timePlayed": 0,
  "sender": "e:*my email*",
  "isDelivered": false
}

@itsjunetime
Copy link
Owner

Ah man, I thought I had this all figured out. It probably won't make any difference for this specific issue, but did you also make sure to upgrade to libsmserver 0.6.4? It includes many improvements that should improve backend stability. (I'm just wondering since I didn't publish the updates on twickd yet, so you may have missed it.)

Also, if possible, could you open up the inspector on your web browser, select the image, and on its parent element (which should be a span), find the attribute called tabpack_guid, and post its value here? It should look something like p:0/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. And could you do the same for the text as well (find its parent element and paste the tapback_guid value here)? That would help a lot.

@sabogalc
Copy link
Author

sabogalc commented Mar 14, 2021

I was unable to find the updated libsmserver version got it, and I suspected that's why I still got issue #96. I am no longer getting issue #96 with libsmserver 0.6.4 and SMServer 0.7.4

Here is the image's tapback_guid - tapback_guid="p:0/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D"

and here is the one for the text - tapback_guid="p:1/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D"

Thank you for the updates!

Edit - On both 0.7.3 and 0.7.4, pinned chats do not display for me anymore. I'm pretty sure this is something wrong from my side and not from SMServer's side, because pinned chats worked fine on version 0.7.3 for a while. I'm not sure what it could be. This only affects my iPhone and not my iPad, as seen here

@sabogalc
Copy link
Author

Screen Shot 2021-03-01 at 12 40 53 PM
mismatch ios
mismatch t
I sent this tapback from my Mac, and it shows up correctly on my WebMessage server, but not in the client. Restarting WebMessage from either device did not fix it.

I've attached an image below which is a reverse of this issue. I applied a tapback from my Mac on the text caption (which can be seen in WebMessage's conversation history) but nothing shows up graphically
tapback thingy

^ So there's something that I had happen in WebMessage. SMServer behaves similarly (SMServer 0.7.4 | libsmserver 0.6.4)
SMServer tapback thingy

@itsjunetime itsjunetime added bug Something isn't working and removed enhancement New feature or request update pending This issue should be fixed with the next update labels Mar 23, 2021
@sabogalc
Copy link
Author

I updated to 0.7.4 and it looks really nice!
Screenshot 2021-03-13 234351
110990580-7e4cb000-8341-11eb-90c0-895fb34372fa
Here is a bug I got for displaying the tapbacks (also seen here)

I love seeing that the Thanos bug is its official name now
Thanos bug

@sabogalc
Copy link
Author

sabogalc commented Apr 5, 2021

Regarding the Thanos message, I was able to get this information from MyMessage. p0 should have a 2003 acknowledgment/tapback and p1 should have a 2004 acknowledgment/tapback. Both are from the same person.

{
  "id": "D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
  "fromMe": true,
  "isTypingMessage": false,
  "description": "We'll show up and he'll be like",
  "flags": 1081349,
  "fileTransferIDs": [
    "72D48466-A535-4C93-AA78-6791A8AB53F1"
  ],
  "chatID": "chat526745548997352517",
  "time": 1615577622383.0002,
  "timeRead": 0,
  "isSOS": false,
  "timeDelivered": 0,
  "isAudioMessage": false,
  "isCancelTypingMessage": false,
  "items": [
    {
      "type": "attachment",
      "payload": {
        "metadata": {
          "size": {
            "width": 500,
            "height": 255
          },
          "id": "72D48466-A535-4C93-AA78-6791A8AB53F1",
          "filename": "AE5727AE-29A7-4E84-B537-17AFD35FEB41.gif",
          "uti": "com.compuserve.gif",
          "mime": "image/gif"
        },
        "id": "p:0/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
        "chatID": "chat526745548997352517",
        "transferID": "72D48466-A535-4C93-AA78-6791A8AB53F1",
        "fromMe": true,
        "time": 1615577622383.0002
      }
    },
    {
      "type": "text",
      "payload": {
        "chatID": "chat526745548997352517",
        "fromMe": true,
        "parts": [
          {
            "type": "text",
            "string": "We'll show up and he'll be like"
          }
        ],
        "id": "p:1/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
        "time": 1615577622383.0002,
        "text": "We'll show up and he'll be like",
        "acknowledgments": [
          {
            "chatID": "chat526745548997352517",
            "sender": "*my friend's email*",
            "associatedID": "p:1/D3DBDAD8-5EEE-4D72-ADB7-20A74501706D",
            "id": "am:F0716C13-6871-4286-A4A6-3CF3FB0B25CD",
            "fromMe": false,
            "time": 1615577636093.2012,
            "acknowledgmentType": 2003
          }
        ]
      }
    }
  ],
  "service": "iMessage",
  "timePlayed": 0,
  "sender": "e:*my email*",
  "isDelivered": false
}

@sabogalc
Copy link
Author

This one isn't that bad since the emphasis is in the right spot, but there is only one shown when there should be three
SMServer Obama
Obama iOS

@sabogalc
Copy link
Author

sabogalc commented Apr 12, 2021

This one has the tapbacks shown in the correct order, but the images are shown out of order. WebMessage behaves exactly the same and MyMessage is a little different
SMServer 3
PNG image (1)

@sabogalc
Copy link
Author

sabogalc commented May 16, 2021

Here is another situation with one message that has four parts of it that are texts and three parts of it that are images. Below is the conversation on iOS
iOS
and in SMServer
SMServer
The text shows in the proper order in MyMessage, and below is the message information that I copied from MyMessage.

{
  "id": "28935DBA-A57E-485E-9442-10FBAD3A3C95",
  "fromMe": true,
  "isTypingMessage": false,
  "description": "Here is a message that has images intermittently scattered throughout it",
  "flags": 1085445,
  "fileTransferIDs": [
    "49CA2847-DF32-4D66-9857-7163EE1FCE49",
    "9C606BB6-2443-4101-A55A-8E2610D08988",
    "00A6CB41-165B-43B8-881F-59D725515B36"
  ],
  "chatID": "*recipient*",
  "time": 1620776404411,
  "timeRead": 0,
  "isSOS": false,
  "timeDelivered": 1620776405263.5593,
  "isAudioMessage": false,
  "isCancelTypingMessage": false,
  "items": [
    {
      "type": "text",
      "payload": {
        "id": "p:0/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "parts": [
          {
            "type": "text",
            "string": "Here is a message"
          }
        ],
        "fromMe": true,
        "time": 1620776404411,
        "text": "Here is a message"
      }
    },
    {
      "type": "attachment",
      "payload": {
        "metadata": {
          "size": {
            "width": 200,
            "height": 200
          },
          "id": "49CA2847-DF32-4D66-9857-7163EE1FCE49",
          "filename": "IMG_1752.png",
          "uti": "public.png",
          "mime": "image/png"
        },
        "id": "p:1/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "transferID": "49CA2847-DF32-4D66-9857-7163EE1FCE49",
        "fromMe": true,
        "time": 1620776404411
      }
    },
    {
      "type": "text",
      "payload": {
        "id": "p:2/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "parts": [
          {
            "type": "text",
            "string": "that has images"
          }
        ],
        "fromMe": true,
        "time": 1620776404411,
        "text": "that has images"
      }
    },
    {
      "type": "attachment",
      "payload": {
        "metadata": {
          "size": {
            "width": 200,
            "height": 200
          },
          "id": "9C606BB6-2443-4101-A55A-8E2610D08988",
          "filename": "IMG_3897.png",
          "uti": "public.png",
          "mime": "image/png"
        },
        "id": "p:3/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "transferID": "9C606BB6-2443-4101-A55A-8E2610D08988",
        "fromMe": true,
        "time": 1620776404411
      }
    },
    {
      "type": "text",
      "payload": {
        "id": "p:4/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "parts": [
          {
            "type": "text",
            "string": "intermittently scattered"
          }
        ],
        "fromMe": true,
        "time": 1620776404411,
        "text": "intermittently scattered"
      }
    },
    {
      "type": "attachment",
      "payload": {
        "metadata": {
          "size": {
            "width": 200,
            "height": 200
          },
          "id": "00A6CB41-165B-43B8-881F-59D725515B36",
          "filename": "IMG_4390.png",
          "uti": "public.png",
          "mime": "image/png"
        },
        "id": "p:5/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "transferID": "00A6CB41-165B-43B8-881F-59D725515B36",
        "fromMe": true,
        "time": 1620776404411
      }
    },
    {
      "type": "text",
      "payload": {
        "id": "p:6/28935DBA-A57E-485E-9442-10FBAD3A3C95",
        "chatID": "*recipient*",
        "parts": [
          {
            "type": "text",
            "string": "throughout it"
          }
        ],
        "fromMe": true,
        "time": 1620776404411,
        "text": "throughout it"
      }
    }
  ],
  "service": "iMessage",
  "timePlayed": 0,
  "sender": "*me*",
  "isDelivered": true
}

@tneotia
Copy link

tneotia commented Dec 13, 2022

See this comment: airmessage/airmessage-android#3 (comment) for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants