Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix the makeup problem. They're all black and white for some reason. #29

Closed
Arronovsky opened this issue Jan 28, 2024 · 19 comments
Closed
Labels
bug Something isn't working question Further information is requested

Comments

@Arronovsky
Copy link

GTA5 2024-01-28 12-46-43

@itsjustcurtis
Copy link
Owner

I don't fully understand how the makeup should work. If you can elaborate on what you expect to see then I can investigate further.

@itsjustcurtis itsjustcurtis added bug Something isn't working question Further information is requested labels Jan 28, 2024
@TayMcKenzieNZ
Copy link

TayMcKenzieNZ commented Jan 28, 2024 via email

@itsjustcurtis
Copy link
Owner

@TayMcKenzieNZ I didn't realise plebmasters had makeup as well. Thanks for sharing

@itsjustcurtis
Copy link
Owner

image

Appears to be functioning correctly. The default state of makeup is un-painted, and the primary and secondary colours need to be changed.

@itsjustcurtis itsjustcurtis closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2024
@Arronovsky
Copy link
Author

In past versions, you didn't have to choose a primary and secondary color in your makeup. Here is an example from the picture. This is the texture of the makeup itself. There are several colors, and in the game it will not look like in the picture, because of the fact that you need to overlay colors. You know what I mean?
makeup

@Arronovsky
Copy link
Author

In version 1.7.5 makeup works properly. I attach a link, you can see the source code and just paste it into your trainer.
https://github.com/MAFINS/MenyooSP/releases/tag/v1.7.5

@itsjustcurtis
Copy link
Owner

itsjustcurtis commented Jan 28, 2024

This is an intentional function added in commit 265 on the Mafins repo. The Feature is functioning as intended, reversing this change would remove the ability to select colour overlays.

@Arronovsky
Copy link
Author

Is there any way to remove it?

@itsjustcurtis
Copy link
Owner

Only by regressing and reversing that change, which I do not intend to do. My objective is to improve and expand the functionality of Menyoo, not reduce it and undo the changes already made. If you have a suggestion on how this can be done without removing functionality, I am open to ideas.

@TayMcKenzieNZ
Copy link

TayMcKenzieNZ commented Jan 28, 2024 via email

@itsjustcurtis
Copy link
Owner

I'm currently investigating, from what I can tell the change was simply to tell the game that makeup can be colourable, there is zero reference to which ones can or can't be painted. I'm trying to see if there is a way I can set the "default" look which can later be changed.

@Arronovsky
Copy link
Author

Have you looked at how the makeups are arranged in the 1.7.5 version?

@Arronovsky
Copy link
Author

Please understand, makeup is a very important thing to many people. And the old version of the trainer do not want to use at all.

@itsjustcurtis
Copy link
Owner

I have, all that has been done is turned the ability to change colour on or off, that is all. I am currently working on a compromise, as being able to colour the makeup is also important. Please have patience.

@Arronovsky
Copy link
Author

Okay, well, thank you for your efforts ❤️

@Arronovsky
Copy link
Author

Why is being able to change the color of your makeup important? Just in the same GTA Online such a function is not. It seems to always use the texture of the original makeup

@itsjustcurtis
Copy link
Owner

Because if it wasn't, then the original change would never have been made. Just because you don't see it as important, doesn't mean others don't. I personally never use the ped stuff in menyoo, but I understand that you want to use it in a way different to me, so I am making it work.

@itsjustcurtis
Copy link
Owner

@Arronovsky please download the last pre-release (v2.0.1a4), this should fix your issue.

@Arronovsky
Copy link
Author

@itsjustcurtis It's all working. Thank you so much! You are the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants