Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize data packet into query string for GET request #7

Closed

Conversation

sico
Copy link
Contributor

@sico sico commented Oct 21, 2014

No description provided.

@sico sico closed this Oct 21, 2014
@itsmattking
Copy link
Owner

PR looked good, why was it closed?

@sico
Copy link
Contributor Author

sico commented Oct 28, 2014

Hey Matt! I actually meant to submit this as a PR for our fork instead --
but also, there were some bugs. Specifically, since the JSON methods
stringify the data hash, submitting an empty hash (which some weirdness in
Cozy code was doing) caused some funkiness to happen, like making nonsense
query strings. If you want to reopen anyway, be my guest! I'm happy to poke
around with it when I have some more time too.

John Sico
m: 717.940.4579
e: john.sico@gmail.com
t: @justabide

On Tue, Oct 21, 2014 at 11:24 PM, Matt King notifications@github.com
wrote:

PR looked good, why was it closed?


Reply to this email directly or view it on GitHub
#7 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants