Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrows on carrousel are invisible when image is white #6

Closed
brunocalou opened this issue Sep 29, 2021 · 7 comments
Closed

Arrows on carrousel are invisible when image is white #6

brunocalou opened this issue Sep 29, 2021 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@brunocalou
Copy link

The arrows are fully white, so when there is a white image, they seem invisible.

I think adding a light border to them would fix this issue and keep the consistency with the other site elements.

Captura de Tela 2021-09-29 às 14 00 33

@itsnitinr itsnitinr added the good first issue Good for newcomers label Sep 29, 2021
@ampsteric
Copy link
Contributor

hey! , would love to work on this issue for hacktoberfest, please assign it to me and add hacktoberfest tag.

@itsnitinr
Copy link
Owner

Here you go. I've added the topic to the repository.

@ampsteric
Copy link
Contributor

image
i tried to implement those matching with the theme of the website , what do you think of it?

@itsnitinr
Copy link
Owner

Awesome job @ampsteric! Could you please share another screenshot without zoom? Just to see how big it would look. Also, is this a gradient?

@ampsteric
Copy link
Contributor

yeah sure.
image

and yeah ,I have added gradients just to make it blend easily with the current theme of driwwwle.

@itsnitinr
Copy link
Owner

Hi @ampsteric, I think the arrows are a little bit bigger and out of position. Please check the original ones. Not sure if it'll look great on mobile view. Since I'm not using gradients anywhere, I think a solid pink shade would be better. What do you say?

Please make a pull request when you're ready and I'll make small edits (if needed). Thanks again!

@itsnitinr
Copy link
Owner

Fixed by #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants