Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carousel button css and alignment. #8

Merged
merged 3 commits into from
Oct 1, 2021

Conversation

ampsteric
Copy link
Contributor

This PR fixes issue #6

  • reduced size of buttons.
  • buttons are in exact positions as previous ones.
  • solid pink shade used instead of gradients.

I have made these changes as discussed in our previous conversation.

I have added all the changes related to CSS in the file Slider_buttons.css.

@ghost
Copy link

ghost commented Oct 1, 2021

Changes to your CodeSee Architecture Map:

View a CodeSee Map of these changes

Legend

CodeSee Map Legend

@itsnitinr
Copy link
Owner

Hi @ampsteric, congratulations on your first contribution! Just a couple of points:

  • Since the project uses TailwindCSS, I would not advise creating a Slider_buttons.css file. We can use the TailwindCSS classes instead. Don't worry, I'll fix it and push the commit.
  • Please add a screenshot of your changes.

I'll merge the PR after some tests and fixes from my side.

Thanks!

@ampsteric
Copy link
Contributor Author

Hi @itsnitinr , I have moved the custom CSS from Slider_buttons.css to TailwindCss in recent commit.
Thanks a lot for being so supportive and kind throughout the process.

Adding the screenshots of the changes below:
image

@itsnitinr
Copy link
Owner

@ampsteric Don't worry about this PR. I'll merge it after some fixes in an hour.

@itsnitinr itsnitinr merged commit aa2f2fb into itsnitinr:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants