Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix top buttons not clickable while video is loading #177

Closed
wants to merge 1 commit into from

Conversation

fowwest
Copy link

@fowwest fowwest commented Apr 29, 2020

There's a bug with top buttons with current version, that is, when video loading view is shown, top buttons like back button is not pressable.
I debugged the cause of the issue and found that it's because loading view is rendered over top buttons covering the entire screen with absolute position.
So i fixed it by switching those two lines as follows:

Before:

{ this.renderTopControls() }
{ this.renderLoader() }

After:

{ this.renderLoader() }
{ this.renderTopControls() }

@kylemilloy
Copy link
Contributor

This has conflicts with the branch now but I've added your changes to 2.5.1. Thanks!

@kylemilloy kylemilloy closed this May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants