Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behavior after upgrade to 2.0.5 #38

Open
dbaio opened this issue Mar 17, 2019 · 9 comments
Open

Different behavior after upgrade to 2.0.5 #38

dbaio opened this issue Mar 17, 2019 · 9 comments
Milestone

Comments

@dbaio
Copy link

dbaio commented Mar 17, 2019

Hi.

We noticed this change after update our build server to itstool 2.0.5, we were using 2.0.2 for a while.

/usr/local/bin/itstool -l pt_BR -m pt_BR.mo -o article.xml article.translate.xml

     <authorgroup>
-      <author><personname><firstname>Bruce</firstname><surname>Montague</surname></personname><affiliation> <address><email>brucem@alumni.cse.ucsc.edu</email>
-          </address> </affiliation></author>
+      <author><personname><firstname>Bruce</firstname><surname>Montague</surname></personname><affiliation> <default:address xmlns="http://docbook.org/ns/docbook"><email>brucem@alumni.cse.ucsc.edu</email>
+          </default:address> </affiliation></author>
     </authorgroup>

Is there a way to disable this insert?
<default:address xmlns="http://docbook.org/ns/docbook">

Part of the xml in question:

<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE article PUBLIC "-//FreeBSD//DTD DocBook XML V5.0-Based Extension//EN" "http://www.FreeBSD.org/XML/share/xml/freebsd50.dtd">
<article xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:its="http://www.w3.org/2005/11/its" version="5.0" xml:lang="en">

  <info><title>Why you should use a BSD style license for your Open Source Project</title>

    <authorgroup>
      <author><personname><firstname>Bruce</firstname><surname>Montague</surname></personname><affiliation>
          <address><email>brucem@alumni.cse.ucsc.edu</email>
          </address>
        </affiliation></author>
    </authorgroup>

And thanks for your time.
Regards.

@shaunix
Copy link
Contributor

shaunix commented Mar 18, 2019

That's weird. It certainly isn't the intended behavior. I'll take a look. Is this in an open source repository I can look at for testing?

@dbaio
Copy link
Author

dbaio commented Mar 18, 2019

This case happened in the FreeBSD doc repository.

https://github.com/freebsd/freebsd-doc

This is the full document
https://github.com/freebsd/freebsd-doc/blob/master/pt_BR.ISO8859-1/articles/bsdl-gpl/article.xml

If you need anything, let me know.

And thank you again.

@UnitedMarsupials-zz
Copy link

@shaunix, according to @dbaio, the 2.0.6 still has the same problem. Could you update us on your own investigation, please?

@shaunix
Copy link
Contributor

shaunix commented May 12, 2019

I've been digging at this all weekend. I'm having a really hard time figuring out why it's happening.

@UnitedMarsupials-zz
Copy link

@shaunix, have you been able to reproduce the problem?

@shaunix
Copy link
Contributor

shaunix commented May 12, 2019

Oh yes, I can absolutely reproduce the problem with the linked-to FreeBSD document. Interestingly, I can't reproduce it with the IT-placeholder-1 regression test, which goes thru the same code paths.

@UnitedMarsupials-zz
Copy link

Well, then you should be able to bisect the commit history to identify, which commit it was... Then, it might dawn on you, which part of the commit is responsible :) Thank you!

uqs pushed a commit to freebsd/freebsd-ports that referenced this issue Jun 17, 2019
This brings back ITS Tool 2.0.2 to the tree because there is an issue
with version 2.0.5 and it is impacting the translation efforts of FreeBSD [1].

I'll keep this version until this problem gets fixed.

1 - itstool/itstool#38

PR:		224903


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@504444 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this issue Jun 17, 2019
This brings back ITS Tool 2.0.2 to the tree because there is an issue
with version 2.0.5 and it is impacting the translation efforts of FreeBSD [1].

I'll keep this version until this problem gets fixed.

1 - itstool/itstool#38

PR:		224903
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this issue Jun 18, 2019
This brings back ITS Tool 2.0.2 to the tree because there is an issue
with version 2.0.5 and it is impacting the translation efforts of FreeBSD [1].

I'll keep this version until this problem gets fixed.

1 - itstool/itstool#38

PR:		224903


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@504444 35697150-7ecd-e111-bb59-0022644237b5
@rozhuk-im
Copy link

Any progreess?

@dbaio
Copy link
Author

dbaio commented Feb 22, 2020

Hi.
I was digging into this and it seems that #18 also fix this issue.
I don't know about the crashes, but it worths to take a look.
Thanks for your time.

Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this issue Mar 14, 2020
…s [1]

FreeBSD Doc translations are working fine with this patch.
More details on itstool/itstool#38

PR:		244325
Approved by:	maintainer timeout (kwm, > 3 weeks)
Obtained from:	itstool/itstool#18 [1]


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@528414 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this issue Mar 14, 2020
…s [1]

FreeBSD Doc translations are working fine with this patch.
More details on itstool/itstool#38

PR:		244325
Approved by:	maintainer timeout (kwm, > 3 weeks)
Obtained from:	itstool/itstool#18 [1]


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@528414 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this issue Mar 14, 2020
…s [1]

FreeBSD Doc translations are working fine with this patch.
More details on itstool/itstool#38

PR:		244325
Approved by:	maintainer timeout (kwm, > 3 weeks)
Obtained from:	itstool/itstool#18 [1]
@shaunix shaunix added this to the 2.1.0 milestone Dec 28, 2020
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this issue Jan 10, 2024
This brings back ITS Tool 2.0.2 to the tree because there is an issue
with version 2.0.5 and it is impacting the translation efforts of FreeBSD [1].

I'll keep this version until this problem gets fixed.

1 - itstool/itstool#38

PR:		224903
svmhdvn pushed a commit to svmhdvn/freebsd-ports that referenced this issue Jan 10, 2024
…s [1]

FreeBSD Doc translations are working fine with this patch.
More details on itstool/itstool#38

PR:		244325
Approved by:	maintainer timeout (kwm, > 3 weeks)
Obtained from:	itstool/itstool#18 [1]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants