Password/pin tabs #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quacklabs
commented
Aug 15, 2019
quacklabs
commented
- changed look of password pin tab
- created a custom input field with floating label
- removed all old components
- Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action.
Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces
- changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead
- Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds
- moved subview removal to before didSetDisplay() block
- Added border around active tab on selection - Remove border around inactive tab on selection of other tab
- Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action.
Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces
- changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead
- Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds
- moved subview removal to before didSetDisplay() block
- Added border around active tab on selection - Remove border around inactive tab on selection of other tab
- Fixed bug where app crashed once input went beyond 5 characters by setting maximum characters to 5 - Resolved PIn strength meter issue by toggling its visibility on PIN commit button action.
Changes suggested on review of Pull request #2 - Updated Cocoapods - fixed typos - removed unneccesary spaces
- changed maximum Int to LONG_MAX - Moved layer clear block to draw function - remove unneccessary type casting on pin lable to improve performance - changed remove from superview block to use an array map style instead
- Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds
- moved subview removal to before didSetDisplay() block
- Added border around active tab on selection - Remove border around inactive tab on selection of other tab
* Fixed issue 384 - Added border color key/value attribute to password & pin tabs on storyboard - added code to change border width on tab activation * deleted decred_wallet.xcworkspace - deleted decred_wallet.xcworkspace * Updated PIN/Password tab - set PIN & Password tab buttons to custom Button class and checked it can be used in storyboard OK - set the button border color * Fixed issue 384 - Added border color key/value attribute to password & pin tabs on storyboard - added code to change border width on tab activation * deleted decred_wallet.xcworkspace - deleted decred_wallet.xcworkspace * Updated PIN/Password tab - set PIN & Password tab buttons to custom Button class and checked it can be used in storyboard OK - set the button border color * Fixed PIN/Password Tab accessibility - added border to bottom and right or left - created function extending projects Button class to add or remove borders accordingly * refactor * cleanup
* remove unused testnet switch, remove save/cancel buttons * cleanup * change Incoming Transaction Notification setting option layout * set compression resistance priority to make label shrink first * delete irrelevant entries from gitignore
* Set password field as first responder * add self on button call * fix typo in comment
* new send page in progress * done with page validations * send refactor complete * cleanup * send confirm - return toproceed * send confirm - return to proceed * more cleanup * move files around * fix send max * ok and view buttons on send success * use single instance of send page to retain view state * don't hide exchange rate label when re-fetching * don't hide usd amount field when re-fetching * correct send amount verification, make amount reduce font size if necessary * resolve send max issues * unset exchange rate value if setting is changed to no exchange rate * punctuate error message * punctuate error message * capitalize exchange rate text in error display, add punctuation
- Removed unwanted comments - Added comments to lines needing clarification. - refactored drawPinLabel to accept an argument containing label bounds
- moved subview removal to before didSetDisplay() block
- Added border around active tab on selection - Remove border around inactive tab on selection of other tab
Startscreen
|
Screenshots before changes Screenshots after changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.