This repository has been archived by the owner on Sep 6, 2020. It is now read-only.
Propagate browserstack local startup errors #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpittarelli
force-pushed
the
master
branch
2 times, most recently
from
a0142de
to
64b45ab
Compare
|
Thanks for the help! Merged and will be releasing a new version soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browserstackLocal.startand.stopcan both fail and they return an error in the standard nodejs callback style (for example: https://github.com/browserstack/browserstack-local-nodejs/blob/ab32965aa6b22c95b256a3c9011f5f53324e7e2c/lib/Local.js#L57). Currently this service silently ignores those errors, causing WDIO to keep going before eventually throwing errors downstream. This PR checks for those errors and propagates them to WDIO via the returned promise.