Fix bug: lose props when use in viewpager+fragment.

ittianyu · Feb 20, 2019 · 5af83a9 · 5af83a9
1 parent a9f9243
commit 5af83a9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -174,7 +174,7 @@ allprojects {
 def support_version = '28.0.0'
 def lifecycle_version = '1.1.1'
 
-implementation 'com.github.ittianyu:relight:0.2.1'
+implementation 'com.github.ittianyu:relight:0.2.2'
 implementation "com.android.support:appcompat-v7:$support_version"
 implementation "com.android.support:design:$support_version"
 

diff --git a/lib/build.gradle b/lib/build.gradle
@@ -9,8 +9,8 @@ android {
     defaultConfig {
         minSdkVersion rootProject.minSdkVersion
         targetSdkVersion rootProject.targetSdkVersion
-        versionCode 21
-        versionName "0.2.1"
+        versionCode 22
+        versionName "0.2.2"
 
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }

diff --git a/lib/src/main/java/com/ittianyu/relight/widget/native_/BaseAndroidWidget.java b/lib/src/main/java/com/ittianyu/relight/widget/native_/BaseAndroidWidget.java
@@ -52,7 +52,6 @@ public abstract class BaseAndroidWidget<V extends View, T extends BaseAndroidWid
     public Integer weight;
     private OnClickListener onClick;
     private RelativeLayout.LayoutParams relativeParams;
-    private boolean addOnAttachListener;
     private OnAttachStateChangeListener onAttachStateChangeListener = new OnAttachStateChangeListener() {
         @Override
         public void onViewAttachedToWindow(View v) {
@@ -71,18 +70,11 @@ public void onViewDetachedFromWindow(View v) {
 
     public BaseAndroidWidget(Context context, Lifecycle lifecycle) {
         super(context, lifecycle);
+        view.addOnAttachStateChangeListener(onAttachStateChangeListener);
     }
 
     protected abstract void initProps();
 
-    @Override
-    public void onStart() {
-        if (!addOnAttachListener) {
-            addOnAttachListener = true;
-            view.addOnAttachStateChangeListener(onAttachStateChangeListener);
-        }
-    }
-
     @Override
     public void onDestroy() {
         super.onDestroy();