Feature/old account remover #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovansky
reviewed
Aug 29, 2021
| { | ||
| var utcDateThreshold = DateTime.UtcNow.Date.AddDays(-thresholdInDays); | ||
| var oldAccounts = await lastUsageRepo.FindLastActivity(token) | ||
| .Where(r => r.LastUsage == null || r.LastUsage < utcDateThreshold) |
There was a problem hiding this comment.
Wydaje mi się, że będzie usuwać, bo wydaje mi się, że jeśli użytkownik się jeszcze nie zalogował na swoje konto - bo np. miał je stworzone w poprzednim przebiegu - to chyba będzie tu zwracać null właśnie?
Jest może opcja tutaj sprawdzenia daty założenia konta, żeby określić wiek minimalny kont do usunięcia tu?
There was a problem hiding this comment.
Dobre spostrzeżenie
Też mi to potem przeszło przez głowę i zapisałem sobie todo w pr. Mamy tam dostęp do daty przyznania licencji (vide testowy csv), myślę, że nie usuniemy kont które dostały licencję w ciągu 60 dni
There was a problem hiding this comment.
Wrzuciłem poprawkę
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.