Personal upstream changes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VottonDev
commented
Feb 27, 2023
| "json-beautify": "^1.1.1", | ||
| "lusca": "1.7.0", | ||
| "mysql2": "^3.1.2", | ||
| "passport": "github:joeyguerra/passport#missing-regenerate-on-req", |
There was a problem hiding this comment.
You may wonder why I'm using a GitHub repo for this, but PassportJS hasn't fixed a problem upstream:
jaredhanson/passport#907
This concerns the version 0.6.0 and fixes a vulnerability in 0.5.3, which is why using the custom version of PassportJS till the fix has been implemented upstream.
This reverts commit 0d0c92c.
|
Got the CI/CD running now with all the current tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes that I've done for Willard Networks, so I would like to push them upstream to patch security problems and generally making the code easier to maintain forward if anybody else uses it.