Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create datapack download script #1214

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Create datapack download script #1214

merged 2 commits into from
Dec 22, 2021

Conversation

cadenkriese
Copy link
Contributor

@cadenkriese cadenkriese commented Dec 19, 2021

Mostly copied from setupModpack script, downloads zip files into $LEVEL/datapacks.

Note that this currently does not handle custom world directories as the setupWorld script also doesn't handle it. Plus I would expect datapacks on Bukkit / derivative servers to be quite a niche case.

Implements #1152

Mostly copied from setupModpack script, downloads zip files into $LEVEL/datapacks.

Note that this currently does not handle custom world directories as the setupWorld script also doesn't handle it. Plus I would expect datapacks on Bukkit / derivative servers to be quite a niche case.
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Do you feel good about the testing of this and ready for me to merge?

@cadenkriese
Copy link
Contributor Author

Yup, I just did a bit more testing to make sure, but it should be good to merge.

@itzg itzg merged commit bf5824b into itzg:master Dec 22, 2021
@itzg
Copy link
Owner

itzg commented Dec 22, 2021

The latest image now includes this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants