Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New RCON commands feature #1391

Merged
merged 9 commits into from Mar 2, 2022
Merged

New RCON commands feature #1391

merged 9 commits into from Mar 2, 2022

Conversation

shotah
Copy link
Contributor

@shotah shotah commented Mar 2, 2022

Adding the ability to run RCON commands at server start, client connect, and client disconnect.

@shotah shotah mentioned this pull request Mar 2, 2022
Closed
@shotah
Copy link
Contributor Author

shotah commented Mar 2, 2022

@itzg Hopefully this gives additional flexibility to the image.

@shotah
Copy link
Contributor Author

shotah commented Mar 2, 2022

@itzg okay really done this time.

itzg
itzg reviewed Mar 2, 2022
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature. I just have some cosmetic suggestions.

README.md Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
examples/docker-compose-rconcmd.yml Outdated Show resolved Hide resolved
files/autopause/autopause-fcns.sh Show resolved Hide resolved
files/rconcmds/rcon-cmds-daemon.sh Outdated Show resolved Hide resolved
files/rconcmds/rcon-cmds-daemon.sh Outdated Show resolved Hide resolved
files/rconcmds/rcon-cmds-daemon.sh Outdated Show resolved Hide resolved
files/rconcmds/rcon-cmds-daemon.sh Outdated Show resolved Hide resolved
@shotah
Copy link
Contributor Author

shotah commented Mar 2, 2022

@itzg Made requested changes.

itzg
itzg reviewed Mar 2, 2022
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one syntax question

files/rconcmds/rcon-cmds-daemon.sh Outdated Show resolved Hide resolved
itzg
itzg approved these changes Mar 2, 2022
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@itzg itzg merged commit 4587b32 into itzg:master Mar 2, 2022
@shotah shotah deleted the dev branch March 2, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itzg itzg itzg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shotah @itzg