Add a support for magma maintained #2552
Conversation
scripts/start-deployMagmaMaintained
Outdated
|
|
||
| resolveVersion | ||
|
|
||
| if ! downloadUrl="https://github.com/magmamaintained/Magma-${VERSION}/releases/download/${MAGMA_MAINTAINED_TAG}/magma-${VERSION}-${FORGE_VERSION}-${MAGMA_MAINTAINED_TAG}-server.jar"; then |
There was a problem hiding this comment.
This if-statement doesn't look right. You have a variable assignment from a literal as a condition. Did you confirm this runs?
There was a problem hiding this comment.
Thank you for your reviewing!
I have tested that the server is correctly downloaded and started. But I have misunderstood the meaning of this if condition. So, I removed that and just replaced it into plain assignment statement with empty variable validation.
There was a problem hiding this comment.
@itzg @aruneko Actual download url is https://github.com/magmamaintained/Magma-1.12.2/releases/download/88659fb/Magma-1.12.2-88659fb-server.jar
Please remove FORGE_VERSION from the script
There was a problem hiding this comment.
#2562 (comment)
download link was correct for >1.18
|
|
||
| !!! note | ||
|
|
||
| There are limited base versions supported, so you will also need to set `VERSION`, such as "1.12.2", "1.18.2", "1.19.3", or "1.20.1". |
There was a problem hiding this comment.
This needs to be indented with four spaces to be rendered within the note.
Can view docs rendering at https://docker-minecraft-server--2552.org.readthedocs.build/en/2552/types-and-platforms/server-types/hybrids/#magma-maintained
There was a problem hiding this comment.
Thanks for finding that.
I have fixed that including other sections in this file.
There was a problem hiding this comment.
Thanks for finding that.
I have fixed that including other sections in this file.
Thanks. Yes, I have been gradually finding other places where I missed the indent.
I have implemented a support for Magma maintained which is an alternative project for terminated Magma project. It supports a bit old versions of Minecraft "1.12.2", "1.18.2", "1.19.3", and "1.20.1".