Use -prune for "REPLACE_ENV_VARIABLES_EXCLUDE_PATHS" feature. #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the -prune option to exclude paths in "find" should be a lot more efficient than -not since it prevents find from traversing excluded directories / files.
itzg
approved these changes
Jul 18, 2020
| @@ -1,5 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| function join_by { local d=$1; shift; echo -n "$1"; shift; printf "%s" "${@/#/$d}"; } | |||
There was a problem hiding this comment.
thing=(abc def 123)
$ printf "%s|" ${thing[@]} | sed 's/.$//'
abc|def|123
What about this?
join(){
local d="${1:?You need a delimiter}"
printf "%s$d" "${@:1}" | sed 's/.$//';
}
the ? in the variable assignment is an assertion - probably a good idea
|
This is now pushed to Docker Hub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the -prune option to exclude paths in "find" should be a lot more efficient than -not since it prevents find from traversing excluded directories / files.