fix: don't echo double backslashes to server.properties #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `sed`, we need to escape double quotes, but with `echo` we can just use the variable as-is. Closes itzg#949
P4sca1
changed the title
itzg
approved these changes
Jul 7, 2021
|
It looks like auto-merging of changes to branches is broken: https://github.com/itzg/docker-minecraft-server/actions/workflows/merge-variants.yml. It fails on merging |
|
Yep, that's by design in GitHub actions. And then I forgot to do the merge myself manually. Doing that now... |
|
Merged and new images pushed |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
sed, we need to escape backslashes, but withechowe can just use the variable as-is.Closes #949