Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rcloneDestDir param #105

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Conversation

wlritchi
Copy link
Contributor

@wlritchi wlritchi commented Feb 6, 2022

Companion PR to itzg/docker-mc-backup#63. Add an rcloneDestDir param to the chart, mapped to the RCLONE_DEST_DIR environment variable for mc-backup.

Fixes #104.

@wlritchi
Copy link
Contributor Author

wlritchi commented Feb 6, 2022

Is it correct to bump the chart version in a PR like this? Not quite sure what the workflow is supposed to be for the helm chart releaser.

@itzg
Copy link
Owner

itzg commented Feb 6, 2022

Is it correct to bump the chart version in a PR like this? Not quite sure what the workflow is supposed to be for the helm chart releaser.

For now, yes it's actually required that PRs bump the version.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great pair of PRs. Thanks!

@itzg itzg merged commit bf5d1ae into itzg:master Feb 6, 2022
@wlritchi wlritchi deleted the rclone-dest-dir-param branch February 6, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rclone backup writes to root directory instead of mounted emptyDir
2 participants