Fix/forward auth redirect #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethklee
changed the title
|
realized, this needs a flag to enable |
itzg
reviewed
Apr 15, 2023
server/server.go
Outdated
| return samlsp.FetchMetadata(reqCtx, client, *idpMetadataUrl) | ||
| reqCtx, cancel := context.WithTimeout(ctx, fetchMetadataTimeout) | ||
| desc, err := samlsp.FetchMetadata(reqCtx, client, *idpMetadataUrl) | ||
| cancel() |
There was a problem hiding this comment.
oops i wasn't supposed to check that in
kennethklee
force-pushed
the
fix/forward-auth-redirect
branch
from
38fd195
to
18ac0d7
Compare
kennethklee
force-pushed
the
fix/forward-auth-redirect
branch
from
18ac0d7
to
9579d3c
Compare
kennethklee
changed the title
|
@itzg ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
This changes:
AttributeHeaderWildcard--auth-verifyflag to enable/_verifyendpoint and trust x-forwarded headers