Support for custom EntityID #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Jan 29, 2024
itzg
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for EntityID SAML option
Azure implementation forces you to use an specific
EntityIDSAML option with the format of"spn:xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx". This PR added this functionality.For the other hand, when using
AttributeHeaderWildcard, session claims can contain slashes (/). In that case, this PR will replace slashes/by hypens-. I'm not sure about this strategy, so I'm open to change if needed.