Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Model#dirtyAttributes at write-time #16

Closed
2 tasks
jordanstephens opened this issue Jan 15, 2020 · 1 comment
Closed
2 tasks

Track Model#dirtyAttributes at write-time #16

jordanstephens opened this issue Jan 15, 2020 · 1 comment
Assignees

Comments

@jordanstephens
Copy link
Contributor

  • Can we track these changes to Model attributes at write-time instead of aggregating them at Model#dirtyAttributes read-time? Maybe via mobx's observe.
  • If we can track this state at write-time, we should be able to derive Model#isDirty directly from this state, rather than via a reaction where we serialize the current attributes. Consider replacing that code as well if the write-time approach is tenable. Let's try to get that serialization off of our write-path!
@jordanstephens jordanstephens self-assigned this Jan 15, 2020
@jordanstephens
Copy link
Contributor Author

This was addressed in #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant