Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating duplicated Digraphs #31

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

iurysza
Copy link
Owner

@iurysza iurysza commented Apr 12, 2024

πŸš€ Description

Fixes a regression where we would generate repeated graph edges.

  • Introduce handling for configuration-specific link texts in DigraphBuilder.
  • Add tests simulating a real project with multiple configurations for each project dependency

πŸ“„ Motivation and Context

πŸ§ͺ How Has This Been Tested?

Unit tests, sample app, real project

πŸ“¦ Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

βœ… Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@iurysza iurysza added the bug Something isn't working label Apr 12, 2024
@iurysza iurysza changed the title Fix DigraphBuilder generating duplicated Digraphs Fix generating duplicated Digraphs Apr 12, 2024
@iurysza iurysza merged commit 8192c07 into main Apr 12, 2024
4 checks passed
@iurysza iurysza deleted the fix-uneeded-edges-when-linktext-is-none branch April 13, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant