Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling for module name parsing #43

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add error handling for module name parsing #43

merged 1 commit into from
Apr 30, 2024

Conversation

iurysza
Copy link
Owner

@iurysza iurysza commented Apr 30, 2024

🚀 Description

Use original string is returned in case of any error during the name parsing method.

📄 Motivation and Context

Solves #39

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)

✅ Checklist

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@iurysza iurysza changed the title Improve Error Handling in Module Name Extraction Add error handling for module name parsing Apr 30, 2024
@iurysza iurysza linked an issue Apr 30, 2024 that may be closed by this pull request
Can't generate module graph #39
Closed
@iurysza iurysza merged commit 00e4d0f into main Apr 30, 2024
4 checks passed
@iurysza iurysza added the bug Something isn't working label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't generate module graph
1 participant
@iurysza