Use "surrogateescape" error handler when encoding unicode paths. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Python 3 functions like os.listdir() always returns unicode paths. "invalid" byte paths are decoded using the "surrogateescape" error handler which must also be used when decoding. See os.fsencodefs() and os.fsdecode().
|
Hmm, I don't like too much the "silent" handling of errors via surogateescape, but if Python itself does this, then it's good enough. |
iustin
added a commit
that referenced
this pull request
May 23, 2014
Use "surrogateescape" error handler when encoding unicode paths.
|
Released in version 0.5.3 (https://pypi.python.org/pypi/pyxattr/0.5.3). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python 3 functions like os.listdir() always returns unicode
paths. "invalid" byte paths are decoded using the "surrogateescape" error
handler which must also be used when decoding.
See os.fsencodefs() and os.fsdecode().