Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error translations #1497

Closed
saltycrys opened this issue Nov 28, 2020 · 7 comments
Closed

Missing error translations #1497

saltycrys opened this issue Nov 28, 2020 · 7 comments
Labels
bug Something isn't working stale type:i18n/l10n Make Invidious usable in other languages, regions and cultures

Comments

@saltycrys
Copy link
Member

saltycrys commented Nov 28, 2020

Missing translations:

  • Login has been disabled by administrator.
  • Account has temporarily been disabled
  • Registration has been disabled by administrator.
  • Administrator has disabled this endpoint.
  • Title cannot be empty.
  • Invalid privacy setting.
  • User cannot have more than 100 playlists.
  • Playlist cannot have more than 500 videos
  • This playlist is private.
  • Video is unavailable.
  • Invalid parameters.
  • Could not extract continuation.
  • Could not extract community tab.
  • Could not extract channel info. Instance is likely blocked.
  • Could not extract channel JSON
  • Could not extract playlist info. Instance is likely blocked.
  • Could not extract playlist info
  • Could not extract author info
  • Invalid scope
  • Invalid signature
saltycrys added a commit to saltycrys/invidious that referenced this issue Nov 28, 2020
Error handling has been reworked to always go through the new `error_template`,
`error_json` and `error_atom` macros.
They all accept a status code followed by a string message or an exception
object. `error_json` accepts a hash with additional fields as third argument.

If the second argument is an exception a backtrace will be printed, if it is a
string only the string is printed. Since up till now only the exception message
was printed a new `InfoException` class was added for situations where no
backtrace is intended but a string cannot be used.

`error_template` with a string message automatically localizes the message.
Missing error translations have been collected in iv-org#1497
`error_json` with a string message does not localize the message. This is the
same as previous behavior. If translations are desired for `error_json` they
can be added easily but those error messages have not been collected yet.

Uncaught exceptions previously only printed a generic message ("Looks like
you've found a bug in Invidious. [...]"). They still print that message
but now also include a backtrace.
@TheFrenchGhosty TheFrenchGhosty added bug Something isn't working priority:medium type:client-side The user interface of invidious labels Nov 28, 2020
Perflyst pushed a commit that referenced this issue Nov 30, 2020
Error handling has been reworked to always go through the new `error_template`,
`error_json` and `error_atom` macros.
They all accept a status code followed by a string message or an exception
object. `error_json` accepts a hash with additional fields as third argument.

If the second argument is an exception a backtrace will be printed, if it is a
string only the string is printed. Since up till now only the exception message
was printed a new `InfoException` class was added for situations where no
backtrace is intended but a string cannot be used.

`error_template` with a string message automatically localizes the message.
Missing error translations have been collected in #1497
`error_json` with a string message does not localize the message. This is the
same as previous behavior. If translations are desired for `error_json` they
can be added easily but those error messages have not been collected yet.

Uncaught exceptions previously only printed a generic message ("Looks like
you've found a bug in Invidious. [...]"). They still print that message
but now also include a backtrace.
@saltycrys
Copy link
Member Author

They are all missing from the locale files. I don't know how those are handled and if they can be edited directly or if they need to be updated through Weblate. If they can be edited directly I'll do so.

@TheFrenchGhosty
Copy link
Member

Blocked because of #1426

@TheFrenchGhosty TheFrenchGhosty added the blocked require something else first label Dec 1, 2020
@syeopite
Copy link
Member

#1426 has been resolved. Shouldn't this issue be unblocked?

@TheFrenchGhosty TheFrenchGhosty removed the blocked require something else first label Mar 22, 2021
@SamantazFox SamantazFox added this to To Do - i18n / l10n in Todo - Invidious Jun 18, 2021
@github-actions
Copy link

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Jul 29, 2022
@SamantazFox SamantazFox added type:i18n/l10n Make Invidious usable in other languages, regions and cultures and removed type:client-side The user interface of invidious stale labels Jul 29, 2022
@unixfox
Copy link
Member

unixfox commented Aug 23, 2022

It would be great to have some documentation about how to add new translations in the code.

@SamantazFox
Copy link
Member

Yes! Good idea!

@github-actions
Copy link

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Aug 24, 2023
Todo - Invidious automation moved this from To Do - i18n / l10n to Done Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale type:i18n/l10n Make Invidious usable in other languages, regions and cultures
Projects
Development

No branches or pull requests

5 participants