Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random big notification Number on the top with the latest build #2764

Closed
solisinvictum opened this issue Jan 5, 2022 · 9 comments · Fixed by #2767
Closed

Random big notification Number on the top with the latest build #2764

solisinvictum opened this issue Jan 5, 2022 · 9 comments · Fixed by #2767
Labels
bug Something isn't working

Comments

@solisinvictum
Copy link

image

I updated Invidious instance today. And now i got everytime a random big number as notification.

@SamantazFox SamantazFox added the bug Something isn't working label Jan 5, 2022
@SamantazFox
Copy link
Member

Thanks for reporting this issue :)

@solisinvictum
Copy link
Author

lol. what a nice reaction :) Thanks.

If you need Logs or some information if needed, tell me and i deliver anything i could.

SamantazFox added a commit to SamantazFox/invidious that referenced this issue Jan 5, 2022
@SamantazFox
Copy link
Member

@solisinvictum Well, I'd appreciate if you could try the PR linked to this issue :)

@solisinvictum
Copy link
Author

solisinvictum commented Jan 5, 2022

Uff. If you tell me how exactly to do this? Because i simply cloned the whole repository and build it.

I look into the commits and look what maybe it could be.

Edit: It seems you was already way faster, because you already submitted a patch :)

Nice work.

@SamantazFox
Copy link
Member

SamantazFox commented Jan 6, 2022

I look into the commits and look what maybe it could be.

Oh, I'm not asking you to fix it XD
There is a Pull Request that is supposed to fix this issue: #2767.

I'm simply asking if you can try it out :)

Uff. If you tell me how exactly to do this? Because i simply cloned the whole repository and build it.

Clone my repository instead, and switch to the fix-subscriptions-not-cleared branch:

git clone https://github.com/SamantazFox/invidious
cd invidious
git checkout fix-subscriptions-not-cleared

Then proceed as per the installation steps :)

@omar-elnaggar
Copy link

The bug still persists on 5a72824.

@SamantazFox
Copy link
Member

The bug still persists on 5a72824.

Does it still happen in 042ff8d (or anything newer than 790b7af) ?

@omar-elnaggar
Copy link

The bug still persists on 5a72824.

Does it still happen in 042ff8d (or anything newer than 790b7af) ?

I do not see the bug on 042ff8d anymore.

@SamantazFox
Copy link
Member

Ok, nice :)

sriegler pushed a commit to sriegler/invidious that referenced this issue Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants