Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Plyr Video Player Option #544

Closed
trymeouteh opened this issue May 21, 2019 · 15 comments
Closed

Feature Request: Add Plyr Video Player Option #544

trymeouteh opened this issue May 21, 2019 · 15 comments
Labels
blocked require something else first feature-request Request of a new feature help wanted Extra attention is needed

Comments

@trymeouteh
Copy link

https://plyr.io/

Plyr is a great video player with a nice UI and easy to use controls. I like using it on mobile devices and find it very user friendly.

I would prefer this over the current video player but I know some people will like the current video player over Plyr. I would to suggest to have them both and in the preferences you can choose which video player to use.

@omarroth
Copy link
Contributor

Quite impressive list of features from a quick look. Unfortunately there's a couple plugins being used with Video.js that I don't see a good Plyr alternative for:

Overall I can see this being an improvement over the current player. Unfortunately I won't have time to look into this much more, but I'd happily look at any PRs adding support for it.

@omarroth omarroth added enhancement Improvement of an existing feature help wanted Extra attention is needed labels May 26, 2019
@elypter
Copy link

elypter commented May 28, 2019

@trymeouteh maybe write a feature suggestion on plyrs github for what is missing if these things are not yet possible with plyr.

@trymeouteh
Copy link
Author

I made a feature request for the video markers on Plyr github. The annotations are legacy if Plyr does not support them, those who want annotations should use the current player. The share button can be added outside the video player and I do believe you can add custom buttons within the player.

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Jan 2, 2021
@Mennaruuk
Copy link

I'd hate for this feature request to be closed. It's such a good idea!! Plyr.io is a beautiful player. I understand the concerns, such as regarding legacy annotations (someone created an issue on it at Plyr's github but unfortunately it was closed.) I hope this can be implemented one day, it'd be a great step forward for Invidious!

@hackerncoder
Copy link
Contributor

Annotations have been removed completely, so they are not a problem anymore.

@github-actions github-actions bot removed the stale label Jan 17, 2021
@Mennaruuk
Copy link

Fan-made concept! (Ignore Firefox's PIP button.)
4c56ffc5-1ee6-4049-9511-165cca5fa138 sketchpad-layerExport

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

@github-actions github-actions bot added the stale label Feb 1, 2022
@Mennaruuk
Copy link

This is a good feature request.

@unixfox unixfox changed the title Feature Request: Ad Plyr Video Player Option Feature Request: Add Plyr Video Player Option Feb 1, 2022
@unixfox
Copy link
Member

unixfox commented Feb 1, 2022

We can't support plyr until this issue is resolved: sampotts/plyr#1455

@unixfox unixfox added feature-request Request of a new feature blocked require something else first and removed enhancement Improvement of an existing feature stale labels Feb 1, 2022
@Mennaruuk
Copy link

Mennaruuk commented Feb 1, 2022

Interesting. Do you know how Invuedious does it? (If you get a connection error, just click the settings and select a working instance like invidious.osi.kr.)

https://bocchilorenzo.github.io/invuedious

@unixfox
Copy link
Member

unixfox commented Feb 1, 2022

They don't use dash, that's it. You can't go over 720p, so they don't offer dash which is a technology that mix both audio and video at the same time. That's what Youtube uses and if you want to watch 1080p+ videos you need to use dash.

More about dash here: https://docs.invidious.io/Geoblocking,-available-video-quality-and-DASH.md

@unixfox
Copy link
Member

unixfox commented Feb 5, 2022

Closing as plyr is going to be abandonned: sampotts/plyr#2408 and the successor only support the very latest version of popular browsers: https://github.com/vidstack/player#%EF%B8%8F-browsers so we don't really want to restrict the amount of people using Invidious.

@unixfox unixfox closed this as completed Feb 5, 2022
@mihar-22
Copy link

mihar-22 commented Feb 7, 2022

Hey @unixfox just to clarify that on Vidstack we're not on the bleeding edge of modern browsers. Pretty much all numbers before our supported versions is 0.00% (see usage table). This is the same support matrix we're using at Reddit, so it's unlikely you're supporting something we're not. Let me know what we're missing that you require.

@unixfox
Copy link
Member

unixfox commented Feb 8, 2022

Hi @mihar-22. Thanks for your comment.

Our user base contains people that are using browsers that are not supported by www.youtube.com and thus use Invidious in order to still watch YouTube videos. This includes the browsers that are way older than the one listed here: https://github.com/vidstack/player#%EF%B8%8F-browsers

We also have users using forks of Firefox, one popular fork: https://www.palemoon.org/. Palemoon is based on Firefox 52.

Unfortunately, the usage statistics from caniuse doesn't represent the real user base of Invidious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked require something else first feature-request Request of a new feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants