Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend memory leak on client devices with livestreams #621

Closed
tuxayo opened this issue Jul 5, 2019 · 10 comments
Closed

Frontend memory leak on client devices with livestreams #621

tuxayo opened this issue Jul 5, 2019 · 10 comments
Labels
bug Something isn't working stale type:client-side The user interface of invidious

Comments

@tuxayo
Copy link

tuxayo commented Jul 5, 2019

OS: Solus
Browser: Firefox 68.0b14

@tuxayo
Copy link
Author

tuxayo commented Jul 5, 2019

I'll retry on Firefox stable and Chromium.
And maybe report and issue to Mozilla, about:memory and about:performance couldn't see the actual RAM usage.

about:memory showed and error message on the process that was hosting the invidious tab.
So maybe it's and upstream issue.

@tuxayo
Copy link
Author

tuxayo commented Jul 5, 2019

(meanwhile if someone else can reproduce that would be a good help)

@omarroth omarroth added the bug Something isn't working label Jul 6, 2019
@Perflyst
Copy link
Contributor

Perflyst commented Jul 6, 2019

I can clearly reproduce this issue in Chromium version 75.0.3770.90

It used around 1.6GB RAM after 1 hour. After 1 hour and 17 minutes the tab crashed.

Screenshot_20190706_122918

@omarroth
Copy link
Contributor

omarroth commented Jul 8, 2019

I expect this is videojs/video.js#5973. #235 may also be relevant.

I haven't kept a tab open long enough to reproduce a crash, but I do observe constant increase in memory on Chrome 75.0.3770.100.

Hopefully there's some more information that can be provided that'll be helpful for the videojs folks. I have a similar heap snapshot to the linked issue, so I believe this is the same issue:

image

@AlexMV12
Copy link

AlexMV12 commented Jul 15, 2019

immagine

Well, I win the prize for more RAM used! :D

I can confirm this bug. It's not the first time, and I saw it happen both on a self-hosted instance and on third parties instances.

In my case I have Firefox and Archlinux.
In the moment I made the screenshot, the tab was hanging: even refreshing it, nothing would happen, and the graphic was broken (as you can see). However, Firefox was still responsive.

The next time it happens I will try to look into the console.

@Prendeon
Copy link

Prendeon commented Mar 3, 2020

Still relevant on Firefox: 73.0.1 and OS: Manjaro, although i don't have anything to add to what has already been mentioned.

@TheFrenchGhosty TheFrenchGhosty changed the title Memory leak with livestreams Frontend memory leak on client devices with livestreams Oct 24, 2020
@TheFrenchGhosty TheFrenchGhosty added priority:high type:client-side The user interface of invidious labels Oct 24, 2020
@SamantazFox
Copy link
Member

Is that issue still relevant? We've updated multiple times videoJS since then, so should be fixed by now.

@unixfox
Copy link
Member

unixfox commented Feb 7, 2022

Is that issue still relevant? We've updated multiple times videoJS since then, so should be fixed by now.

Probably, videojs/video.js#5973 is still opened at videojs.

@matthewmcgarvey
Copy link
Contributor

They never scheduled time 😢

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale type:client-side The user interface of invidious
Projects
None yet
Development

No branches or pull requests

9 participants