Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memleak on live m3u8 when not start playing #5973

Open
0caspy opened this issue Apr 30, 2019 · 7 comments
Open

memleak on live m3u8 when not start playing #5973

0caspy opened this issue Apr 30, 2019 · 7 comments

Comments

@0caspy
Copy link

0caspy commented Apr 30, 2019

Description

If open player with live m3u8, but not press start/play, memory will leak not releasing constantly refreshing m3u8.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. create player with live HLS stream.
  2. open it, but NOT press play
  3. wait and look for memory

Results

Expected

Constant memory usage

Actual

Memory usage increase
in 'heap snapshot' (chrome) i see strings objects with m3u8 content.
but outdated content not released, thus adding new string with refreshed m3u8 content every 'target duration' seconds.
as soon as you press 'play', no more string will be leaking. an outdated objects will be released on each m3u8 update.

Error output

no errors

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

7.5.4

browsers

Crome.
may be others too.

OSes

MacOS Mojave in my case

plugins

no plugins

@0caspy
Copy link
Author

0caspy commented Apr 30, 2019

if put video on pause - the same story. memory not released upon m3u8 update

@gkatsev
Copy link
Member

gkatsev commented Apr 30, 2019

Hey, can you show us where in the heap snapshot you were finding the m3u8s? Would make it easier for us to track it down and make sure we're on the same page.

@gkatsev
Copy link
Member

gkatsev commented May 1, 2019

I looked at it a bit yesterday and I have one simple fix (videojs/http-streaming#487), there's definitely a lot more we need to do.

@0caspy
Copy link
Author

0caspy commented May 2, 2019

Hey, can you show us where in the heap snapshot you were finding the m3u8s? Would make it easier for us to track it down and make sure we're on the same page.

please, take a look on two screenshots.
normal, while playing
leaked, when not playing

@gkatsev
Copy link
Member

gkatsev commented May 17, 2019

Thanks! We're definitely going to schedule time to investigate the memory leaks.

@stale
Copy link

stale bot commented Jul 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Jul 16, 2019
@gkatsev gkatsev added confirmed and removed outdated Things closed automatically by stalebot labels Jul 16, 2019
@zsilbi
Copy link

zsilbi commented Apr 30, 2023

The source of this leak is in the m3u8 parser: videojs/m3u8-parser#164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants