Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playlist page and endpoint #116

Merged
merged 1 commit into from Aug 17, 2018
Merged

Add playlist page and endpoint #116

merged 1 commit into from Aug 17, 2018

Conversation

omarroth
Copy link
Contributor

@omarroth omarroth commented Aug 16, 2018

Playlists have a significant amount of functionality behind them, most of which has already been split into separate issues (#113, #18 , #114). Currerntly this PR adds a /playlist page and /api/v1/playlists/:plid endpoint. This likely won't be merged until playlists have been integrated into the player, but I'd like to have this open for people to comment on.

For integration into the player, I'd be curious to know if there's anything that could handle #18 or #114, or if it would be better to make a custom solution. A custom solution probably won't look pretty. I would appreciate feedback on this.

@omarroth omarroth mentioned this pull request Aug 17, 2018
@omarroth omarroth changed the title Add playlists Add playlist page and endpoint Aug 17, 2018
@omarroth
Copy link
Contributor Author

I think I'll merge this, and close #16 once playlists have been integrated into the player.

@omarroth omarroth merged commit 4760b3c into master Aug 17, 2018
@omarroth omarroth deleted the add-playlists branch August 17, 2018 16:01
@omarroth omarroth restored the add-playlists branch September 6, 2018 15:54
@omarroth omarroth deleted the add-playlists branch September 6, 2018 20:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant