Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore "/" key handling if search box is focused #2846

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Ignore "/" key handling if search box is focused #2846

merged 1 commit into from
Jan 30, 2022

Conversation

SamantazFox
Copy link
Member

Fixes a side effect of #2814
See: #2791 (comment)

@SamantazFox SamantazFox requested a review from a team as a code owner January 28, 2022 17:19
@SamantazFox SamantazFox requested review from unixfox and removed request for a team January 28, 2022 17:19
@SamantazFox
Copy link
Member Author

Deployed on https://test.invidious.io

@SamantazFox SamantazFox added in-testing This feature has been deployed and is being tested need-code-review A crystal developper need to check if the code is correct. labels Jan 28, 2022
@SamantazFox SamantazFox force-pushed the SamantazFox-fix-search-focus-js branch from 16f0abc to abd7f7f Compare January 30, 2022 01:51
@SamantazFox SamantazFox force-pushed the SamantazFox-fix-search-focus-js branch from abd7f7f to 15c66e2 Compare January 30, 2022 22:28
@SamantazFox
Copy link
Member Author

SamantazFox commented Jan 30, 2022 •
edited
Loading

(re)deployed on https://test.invidious.io

@SamantazFox SamantazFox removed need-code-review A crystal developper need to check if the code is correct. in-testing This feature has been deployed and is being tested labels Jan 30, 2022
@SamantazFox SamantazFox merged commit 2289f98 into master Jan 30, 2022
@SamantazFox SamantazFox deleted the SamantazFox-fix-search-focus-js branch January 30, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmcgarvey matthewmcgarvey matthewmcgarvey left review comments

@unixfox unixfox Awaiting requested review from unixfox unixfox is a code owner automatically assigned from iv-org/developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SamantazFox @matthewmcgarvey