YT Comments: parse isPinned and strikethroughs #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkyProgrammer
requested review from
SamantazFox
and removed request for
a team
SamantazFox
reviewed
Feb 9, 2023
Co-authored-by: Samantaz Fox <coding@samantaz.fr>
SamantazFox
approved these changes
Feb 10, 2023
|
Thanks for your contribution :) |
SamantazFox
added a commit
to SamantazFox/invidious
that referenced
this pull request
Feb 12, 2023
"pinnedCommentBadge" is not a boolean, but a complex structure. This commit fixes a wrong assumption I had during the rewiew of iv-org#3626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only added api support for isPinned but strikethroughs can be displayed in Invidious with this PR:
Before:
After:
YouTube:
Link to comment: https://www.youtube.com/watch?v=OqiXFXlYFi8&lc=UgxpIdc1QlWErEUhbkZ4AaABAg