improve accessibility #3710
Merged
improve accessibility #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamantazFox
approved these changes
Apr 1, 2023
Co-Authored-By: Samantaz Fox <coding@samantaz.fr>
SamantazFox
approved these changes
Apr 10, 2023
|
Thanks again for contributing ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used eslint to look for potential issues in the js files (One issue not addressed in this PR is that the Url object is not supported on IE 11, this is used in a few places)
I used stylelint to find some potential issues in the css (some elements had hover but were missing focus)
I added alt tags to all images to improve accessibility.
See: https://www.w3.org/WAI/tutorials/images/decorative/