New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Redis for caching #3815
base: master
Are you sure you want to change the base?
Use Redis for caching #3815
Conversation
1b1bc89
to
890aebd
Compare
5b087ca
to
fe8ed6b
Compare
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
What do you think about splitting the video cache into two? One for the streaming urls and the other for the metadata. We'd be able to persist the metadata for a lot longer than 6 hours then. |
fe8ed6b
to
73160f4
Compare
That could be doable, I think. I guess you want the metadata to be used for imports or playlists? |
Yep. From what I can see Invidious also often calls |
73160f4
to
0641c5c
Compare
In the end, I think I'll go with that separation:
|
Titles should probably just be included as a part of As for |
I know that titles may change (especially true when the video was recently released, to boost views). The main goal is to address #1356 and/or #3959 + #3035, which requires a long cache time.
So you'd wand it with the metadata? Or separated? In all cases, all data will be refreshed whenever the video needs to be played. |
Either or is fine. I'm just not entirely sure why captions and storyboards are placed under |
0641c5c
to
e998a10
Compare
e998a10
to
07dc015
Compare
07dc015
to
47d9f40
Compare
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
Closes #3628