Remove lsquic entirely #4008
Merged
Remove lsquic entirely #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
requested review from
TheFrenchGhosty,
SamantazFox,
unixfox and
a team
as code owners
|
Amoeba is broken on Crystal 1.9. See crystal-ameba/ameba#372. Once v1.5 of Ameba comes out it should be fixed. |
unixfox
approved these changes
Jul 26, 2023
SamantazFox
added
the
need-testing
|
I would like to merge this because I have been using invidious without quic compiled for months and this works great. |
|
Safe to merge then? |
|
Well that's what I wanted to do. Not sure about @SamantazFox |
|
Merging as it's has been stable for a long time now. |
SamantazFox
removed
the
need-testing
999eagle
added a commit
to 999eagle/nixpkgs
that referenced
this pull request
Feb 19, 2024
lsquic hasn't been used in upstream since iv-org/invidious#4008
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work fine though I have no way of making sure the storyboard functionalities are kept since I can't test that on my local instance. It should be tested just in case.
Close #3752