Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlists: Use subtitle when author is missing #4025

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

ChunkyProgrammer
Copy link
Contributor

Example playlists:
One artist: https://www.youtube.com/playlist?list=OLAK5uy_lM3m05hKVY9vbzZH5lJpVKZKUQ-v_iTz4
Two artists: https://www.youtube.com/playlist?list=OLAK5uy_mYnfMbIG74obySLdWtKKGj_MJ-YZqVTu0

Related:
LuanRT/YouTube.js#458

Screenshots:

Without this PR (Artist not displayed) Empty artist field
With this PR (one artist displayed): SIA as the artist
With this PR (two artists displayed) SIA and David Guetta as the artist

@ChunkyProgrammer ChunkyProgrammer requested a review from a team as a code owner August 1, 2023 16:02
@ChunkyProgrammer ChunkyProgrammer requested review from syeopite and removed request for a team August 1, 2023 16:02
src/invidious/views/playlist.ecr Outdated Show resolved Hide resolved
@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Aug 28, 2023
@SamantazFox SamantazFox added ready and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Sep 10, 2023
@SamantazFox SamantazFox changed the title Playlist: Use subtitle when author is missing Playlists: Use subtitle when author is missing Sep 18, 2023
@SamantazFox SamantazFox merged commit bb14f79 into iv-org:master Sep 18, 2023
8 checks passed
@SamantazFox
Copy link
Member

Thanks for the PR :D

@ChunkyProgrammer ChunkyProgrammer deleted the playlist-subtitle branch September 18, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants