force resolve for everything #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixfox
requested review from
syeopite and
SamantazFox
and removed request for
a team
|
Confirmed on matrix that it's critical for sending all the traffic with the correct IP version so that the public instance gets fully unblocked. |
syeopite
reviewed
Nov 2, 2023
SamantazFox
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only www.youtube.com was forced resolved, but now all the traffic will be force resolved to whatever IP version the user specify.
This is for being sure that all the proxy to googlevideo.com is being sent in the correct specified IP version. This will help for the issue #4045
I did test and this doesn't break anything. When nothing is forced, the default value is used: https://github.com/iv-org/invidious/blob/master/src/invidious/config.cr#L122