API: Remove the fields parameter
#4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/iv-org/invidious/actions/runs/6933226444/job/18858928182?pr=4276 APIHandler is still being called |
SamantazFox
force-pushed
the
remove-fields-param
branch
from
a538cf3
to
7b6930c
Compare
|
@syeopite thanks! |
|
Just adding a note here, as a reminder that the docs will need updating after this is merged. |
SamantazFox
added
the
need-testing
SamantazFox
added
ready
and removed
need-testing
iBicha
reviewed
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Multiple users have reported that the
fieldsparameter is slowing down API response times significantly.As most API endpoints are already optimized to make as few requests as possible to Youtube, there is no point in limiting the output. Furthermore, the added processing might be part of the memory leak problem (#1438).
In addition, I'm certain that the small increase in data output is not much of an issue when we have a huge video proxy next to it.
Possible caveats
This might break some people's bash scripts that relied on this parameter to reduce the received JSON output. In my opinion, this is not a bit concern, we can recommend using
jqfor that purpose.