Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add microphone filtering #22

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Add microphone filtering #22

merged 1 commit into from
Jan 6, 2020

Conversation

rbray89
Copy link
Contributor

@rbray89 rbray89 commented Dec 13, 2019

This change introduces pulseaudio as a go-between for audio processing so that we can use the echo-cancel module to "clean up" the microphone. This is especially useful when white-noise machines are running in the background.

@ivadim
Copy link
Owner

ivadim commented Dec 30, 2019

Hi @rbray89
This looks awesome. I tried myself to setup filtering before using containers but configuration became too complex...

Can I ask you to fix small issues before I merge this?

  • You removed this line:
- ./configuration/nginx/.htpasswd:/etc/nginx/.htpasswd

idea behind this as you can setup nginx password before running container...

  • Build is failing with error
Step 4/5 : COPY audio_entry.sh /
COPY failed: stat /var/lib/docker/tmp/docker-builder519891823/audio_entry.sh: no such file or directory

it happens because working directory is outside of the current Docker file's directory...

docker build . -f docker/$(stage.name)/Dockerfile -t $(container.name)

docker build . -f docker/$(stage.name)/Dockerfile -t $(container.name)

I think you can just add cd to docker/$(stage.name)

@ivadim ivadim merged commit 6e1ccd8 into ivadim:master Jan 6, 2020
@ivadim
Copy link
Owner

ivadim commented Jan 6, 2020

@rbray89 thank you for the contribution 🙇 . I'll fix the build later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants