Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification function #24

Merged
merged 26 commits into from
Jan 6, 2020
Merged

Notification function #24

merged 26 commits into from
Jan 6, 2020

Conversation

jeremyfritzen
Copy link
Contributor

Added a Notification feature to notify the user when the temperature is outside a range.
The user is notified by Pushbullet service.

@ivadim
Copy link
Owner

ivadim commented Dec 30, 2019

Hi @jeremyfritzen
I like the idea 👍 Only thing I would change is use one container image for both "fruitnanny" and "notification" parts. This should reduce number of bits to transfer over wire and disk space.

- Based notification image build on the ivadim/fruitnanny image
- Changed the way the container will retrieve the temperature.py script (mounted volume instead of a COPY)
@jeremyfritzen
Copy link
Contributor Author

Hi @jeremyfritzen
I like the idea 👍 Only thing I would change is use one container image for both "fruitnanny" and "notification" parts. This should reduce number of bits to transfer over wire and disk space.

You're right! Thanks for your advice.
Since I needed to add something to the original Fruitnanny image, I changed the Notification dockerfile to base the build on Fruitnanny and then to add my new packages.

It works like a charm :)

- Created a "configuration" file for notification feature
- Added "motion detection" to Notification feature (being notified when a motion is detected)
- Fixed the type of temp_min and temp_max variables
- Uncommented the loop
@rayrrr
Copy link

rayrrr commented Jan 3, 2020

also of potential interest: https://gitlab.com/PushFish

@jeremyfritzen
Copy link
Contributor Author

Thanks!
I've never heard about Pushfish but it seems very interesting since it's self-hosted!
It also seems to be still under development

@@ -16,7 +16,7 @@ services:

gstreamer-video:
image: ivadim/fruitnanny-gstreamer
restart: always
restart: "no"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to set restart to "no"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a mistake, sorry.
I changed it for my tests because I didn't want containers to be restarted after a RPi reboot.

@ivadim ivadim merged commit c894bd3 into ivadim:master Jan 6, 2020
@ivadim
Copy link
Owner

ivadim commented Jan 6, 2020

Thank you 🙇

@ivadim
Copy link
Owner

ivadim commented Jan 7, 2020

Hi @jeremyfritzen
I've updated installation little bit and made notifications part optional...

  • Run the system without notifications
cd /opt/fruitnanny
docker-compose up -d
  • Run the system with notifications
cd /opt/fruitnanny
docker-compose -f docker-compose.yml -f docker-compose.notification.yml up -d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants