Skip to content

Commit

Permalink
Test upgrades for pinned dependencies to improve downstream compatibi…
Browse files Browse the repository at this point in the history
…lity (#1308)

* `requirements.txt`: Update `nibabel` to `5.x`

* `requirements.txt`: Unpin `pyparsing`

The comment that justifies the pin specifically references `packaging==21.2`, but the latest version of `packaging` is actually `23.2`, i.e. 2 years after the version that required the pin.

Given all the years that have passed, I trust that things have resolved themselves such that pip will handle (skip) any incompatible package versions from two years ago.

* `requirements.txt`: Remove upperbound for `pandas`

* `requirements.txt`: Update `pandas` upper bound to 2.0

---------

Co-authored-by: Kanishk Kalra <36276423+kanishk16@users.noreply.github.com>
  • Loading branch information
joshuacwnewton and kanishk16 committed Mar 11, 2024
1 parent 881dc68 commit 592485a
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions requirements.txt
@@ -1,22 +1,16 @@
# workarounds for pip 20.0.2's buggy dependency resolver
# which doesn't account for cross-package constraints: https://pip.pypa.io/en/stable/user_guide/#changes-to-the-pip-dependency-resolver-in-20-3-2020
# matplotlib pulls in the latest pyparsing, nibabel pulls in the latest packaging, and the two latests are in conflict.
# > ERROR: packaging 21.2 has requirement pyparsing<3,>=2.0.2, but you'll have pyparsing 3.0.5 which is incompatible.
# This forces the older pip, if the user has the older pip, to behave itself.
# This is to specially support users on Ubuntu 20.04 LTS; when Ubuntu 22.04 LTS comes out, this can be removed.
pyparsing<3,>=2.0.2
csv-diff>=1.0
loguru~=0.5
imageio>=2.31.4
joblib~=1.0
matplotlib>=3.3.0
nibabel~=3.2
nibabel~=5.2
onnx
# 1.7.0>onnxruntime>=1.5.1 required `brew install libomp` on macOS.
# So, pin to >=1.7.0 to avoid having to ask users to install libomp.
# Avoid version 1.16.0 due to: https://github.com/spinalcordtoolbox/spinalcordtoolbox/issues/4225
onnxruntime>=1.7.0,!=1.16.0
pandas>=1.1,<1.5.0
# `pandas==2.0` removed the `DataFrame.append` call, which we currently use in approx. 13 places (per PyCharm search)
pandas>=1.1,<2.0
pybids>=0.14.0,<0.15.6
scikit-learn>=0.20.3
scikit-image~=0.17
Expand Down

0 comments on commit 592485a

Please sign in to comment.