Skip to content

Commit

Permalink
Support python3.10 (#1137)
Browse files Browse the repository at this point in the history
On python3.10, this requires on onnxruntime>=1.12, because that's their only version that has builds published for python 3.10. But earlier should be able to stick with earlier onnxruntimes. To support that, switch from `onnxruntime==1.7.0` to `~=1.7`, aka `>=1.7,<2`.

While we're here, also, put upper-bounds on `torch`, because we're worried about shifting too many core dependency too much all at once.

We know this dependency policy is inconsistent. We will try to clean it up in #1191.

Co-authored-by: Etienne Boucher <etienne.boucher@polymtl.ca>
Co-authored-by: Kanishk Kalra <36276423+kanishk16@users.noreply.github.com>
Co-authored-by: Yuan Wang <wang17@ualberta.ca>
  • Loading branch information
4 people committed Aug 7, 2022
1 parent 81f5691 commit dee79e6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:

matrix:
os: [ "macos-latest", "windows-latest", "ubuntu-20.04", "ubuntu-18.04" ]
python-version: [3.7, 3.8, 3.9 ]
python-version: [ '3.7', '3.8', '3.9', '3.10' ]
test-name:
- integration-test

Expand Down
6 changes: 3 additions & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ imageio~=2.19
joblib~=1.0
matplotlib>=3.3.0
nibabel~=3.2
onnxruntime==1.7.0
onnxruntime~=1.7
pandas~=1.1
pybids>=0.14.0
scikit-learn>=0.20.3
Expand All @@ -21,6 +21,6 @@ tensorboard>=1.15.0
tqdm>=4.30
scipy
torchio>=0.18.68
torch~=1.8.1
torchvision~=0.9.1
torch>=1.8.1,<=1.11.0
torchvision>=0.9.1,<=0.12.0
wandb>=0.12.11
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
'Intended Audience :: Developers',
'Programming Language :: Python :: 3',
],
python_requires='>=3.7,<3.10',
python_requires='>=3.7,<3.11',
packages=find_packages(exclude=['docs', 'tests']),
include_package_data=True,
install_requires=requirements,
Expand Down

0 comments on commit dee79e6

Please sign in to comment.