Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typehint for loader/film.py #1151

Merged
merged 4 commits into from
Nov 20, 2022
Merged

Typehint for loader/film.py #1151

merged 4 commits into from
Nov 20, 2022

Conversation

cakester
Copy link
Contributor

@cakester cakester commented Jun 7, 2022 •
edited
Loading

Checklist

GitHub

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've assigned a reviewer

PR contents

Description

add type hinting for loader/film.py

Linked issues

@cakester cakester requested a review from dyt811 June 7, 2022 17:01
@coveralls
Copy link

coveralls commented Jun 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3498700780

  • 12 of 16 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 69.046%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ivadomed/loader/film.py 12 16 75.0%
Totals Coverage Status
Change from base Build 3498647023: -0.02%
Covered Lines: 4247
Relevant Lines: 6151
💛 - Coveralls

@dyt811 dyt811 merged commit 33a8960 into master Nov 20, 2022
@dyt811 dyt811 deleted the hm/typehint_film branch November 20, 2022 02:33
@mariehbourget mariehbourget added the refactoring PRs/Issues that solely deal with existing code reorganization label Jan 3, 2023
@mariehbourget mariehbourget added this to the new release milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyt811 dyt811 dyt811 approved these changes

Assignees
No one assigned
Labels
refactoring PRs/Issues that solely deal with existing code reorganization
Projects
None yet
Milestone
v2.9.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cakester @coveralls @dyt811 @mariehbourget