-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests README: Add instructions to install testing-related packages #1180
Tests README: Add instructions to install testing-related packages #1180
Conversation
Pull Request Test Coverage Report for Build 2770497171
💛 - Coveralls |
Good call. I agree. This was actually because we USED to have a requirement file for those for dev specifically but since a recent PR streamlining the installation process, it has been borked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for running through the install process and catching these problems. These are the sorts of things that fall through the cracks when people write software together. See my comments abovebelow for what I think should be done.
I'm sorry it got lost in my inbox @mathieuboudreau.
Co-authored-by: Nick <nick@kousu.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mathieuboudreau as we would have definitely missed this! LGTM apart from a minor suggestion which is continuation to Nick's comment.
Thank you all for your reviews and suggestions! Merging! |
Checklist
GitHub
PR contents
Description
In the testing/ README, it was previously assumed that you already had
pytest
andpytest_console_scripts
already installed, but these are not installed along with the IVADOMED requirements. I've added instructions to install them, otherwise users might get an error (I did).Linked issues