Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop testing on macOS 10 #1190

Merged
merged 2 commits into from
Aug 7, 2022
Merged

Drop testing on macOS 10 #1190

merged 2 commits into from
Aug 7, 2022

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Aug 3, 2022

Checklist

GitHub

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've assigned a reviewer

PR contents

Description

See actions/runner-images#5583

We should perhaps later re-add "macos-11" when "macos-latest" becomes "macos-12"

See actions/runner-images#5583

We should perhaps later re-add "macos-11" when "macos-latest" becomes "macos-12"
@kousu kousu requested a review from dyt811 August 3, 2022 19:22
@kousu
Copy link
Contributor Author

kousu commented Aug 3, 2022

(The lack of) This just blocked #1137 in https://github.com/ivadomed/ivadomed/actions/runs/2791716988:

Screenshot 2022-08-03 at 15-22-54 Support python3 10 · ivadomed_ivadomed@974b971

@coveralls
Copy link

coveralls commented Aug 3, 2022

Pull Request Test Coverage Report for Build 2791911499

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 69.353%

Totals Coverage Status
Change from base Build 2771735045: 0.2%
Covered Lines: 4277
Relevant Lines: 6167

💛 - Coveralls

@kousu kousu added bug category: fixes an error in the code testing Test related change Ready for review Mark PR that are ready to be reviewed. CI category: TravisCI, GitHub Actions, etc. labels Aug 6, 2022
@kanishk16 kanishk16 self-requested a review August 7, 2022 14:43
@kousu kousu mentioned this pull request Aug 7, 2022
7 tasks
Copy link
Contributor

@kanishk16 kanishk16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was long overdue... Thanks for taking care of this!

@kousu kousu merged commit c7b8b94 into master Aug 7, 2022
@kousu kousu deleted the nc/ci-bye-macos10 branch August 7, 2022 15:41
@mariehbourget mariehbourget added this to the new release milestone Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: fixes an error in the code CI category: TravisCI, GitHub Actions, etc. maintenance Ready for review Mark PR that are ready to be reviewed. testing Test related change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants