Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to CUDA-11 #951

Merged
merged 3 commits into from Oct 12, 2021
Merged

Pin to CUDA-11 #951

merged 3 commits into from Oct 12, 2021

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Sep 22, 2021

This makes ivadomed compatible with our state-of-the-art internal GPU cluster.

Checklist

GitHub

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've assigned a reviewer

PR contents

Description

Linked issues

This makes ivadomed compatible with our state-of-the-art internal GPU cluster.
@kousu
Copy link
Contributor Author

kousu commented Sep 22, 2021

As I said, this makes this work on romane.neuro.polymtl.ca. According to @mariehbourget and @uzaymacar the upgrade functions without obvious bugs. However I'm unsure if this will cause problems for users on older hardware.

requirements_gpu.txt Outdated Show resolved Hide resolved
@kousu
Copy link
Contributor Author

kousu commented Oct 9, 2021

For the record: we talked this over at our meetings and Yang researched what hardware is out there and it seems that all GPUs manufactured in the last decade should be compatible with this. So we're just going to go for it.

kousu and others added 2 commits October 9, 2021 17:52
I copy-pasted it off a working configuration, but it's irrelevant for ivadomed..hopefully?
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1331056276

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.777%

Totals Coverage Status
Change from base Build 1327040703: 0.0%
Covered Lines: 4316
Relevant Lines: 6098

💛 - Coveralls

@dyt811 dyt811 merged commit 5207e7a into master Oct 12, 2021
@dyt811 dyt811 deleted the ng/cuda-11 branch October 12, 2021 02:32
@dyt811 dyt811 added this to the new release milestone Nov 15, 2021
@dyt811 dyt811 added the dependencies Pull requests that update a dependency file label Nov 15, 2021
@kousu kousu mentioned this pull request May 26, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants