This repository has been archived by the owner on Dec 22, 2018. It is now read-only.
Paperclip and test suite update #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated Paperclip to the latest version (although it is now deprecated and no longer supported). I'm hoping this might fix some local issues we've been having with attachments, although I need to try and replicate these issues locally on development.
I've also added a more specific test for attaching JPEGs, as the current test only appears to check if PDFs can be attached.
I've noticed that all tests regarding attachments (certainly for PDFs) don't appear to work on Ubuntu 16.04 - this may be an incompatibility with ImageMagick, Ghostscript or something else. The tests appear to run (and pass) on Ubuntu 14.04 on Travis, but I don't know if there's an option to try newer VMs (Ubuntu 14.04 goes EOL in March 2019).